Merge pull request #243 from fdnd-agency/242-cicd-as-a-developer-i-want-to-automatically-test-and-deploy-the-sveltekit-project-using-github-actions-so-we-can-catch-errors-early-and-deploy-faster
242 cicd as a developer i want to automatically test and deploy the sveltekit project using GitHub actions so we can catch errors early and deploy faster
chore: define browser globals as readonly in ESLint config #242
- Added `setTimeout` and `history` to ESLint globals with 'readonly' access
to avoid false "not defined" errors in +layout.svelte.
- These globals are only available in the browser (not during SSR), but are safely
guarded with `typeof window !== "undefined"`. Declaring them as readonly ensures
ESLint accepts their use without disabling useful rules like `no-undef`.
Refs #242
feat: use resolve() for internal links to fix ESLint errors #242
This commit updates all internal <a> tags to use resolve() from $app/paths,
as required by SvelteKit's ESLint rule `svelte/no-navigation-without-resolve`.
Affected components:
- MobileNav.svelte
- Navbar.svelte
- Sidebar.svelte
- +error.svelte
These changes improve routing reliability and fix all related linting issues.
Refs #242
feat: resolved ESLint issues in Svelte components. #242
This commit fixes multiple ESLint errors to improve code quality and SSR safety:
- added missing keys to each blocks
- guarded browser-specific globals like window and document
- removed unused variables
- updated <a> tags to use resolve() for internal navigation
- configured ESLint with global definitions for browser context
Part of issue #242
Merge branch '242-cicd-as-a-developer-i-want-to-automatically-test-and-deploy-the-sveltekit-project-using-github-actions-so-we-can-catch-errors-early-and-deploy-faster' of https://github.com/fdnd-agency/footguard into 242-cicd-as-a-developer-i-want-to-automatically-test-and-deploy-the-sveltekit-project-using-github-actions-so-we-can-catch-errors-early-and-deploy-faster
Merge branch 'dev' into 242-cicd-as-a-developer-i-want-to-automatically-test-and-deploy-the-sveltekit-project-using-github-actions-so-we-can-catch-errors-early-and-deploy-faster
fix: remove unused className prop from Heading component #247
This commit removes the unused className prop from Heading to resolve
ESLint no-unused-vars warnings.
Refs #247
fix: add key to email each block #244
Add unique key (email.id) to each block to ensure correct item tracking and reactivity.
- Import `resolve` from $app/paths
- Wrap query string with resolve() for correct path resolution
- Remove void prefix as return value is now handled properly
fix: remove unused props from SearchBar component #247
This commit removes the unused 'className' and 'form' props to resolve ESLint warnings.
Refs #247
fix: clean up CompareGradingTable unused imports and add each key #247
This commit removes unused variables and component imports from QuestionsForm.
Refs #247
fix: clean up CompareGradingTable unused imports and add each key #247
This commit removes unused variables and component imports from CompareGradingTable
and adds a required key to the each block to satisfy ESLint and Svelte rules.
Refs #247
fix: clean up unused imports and improve rendering #244
Remove unused component imports
- Remove unused Svelte helpers (onMount) and variables (form, gradings)
- Add key to each block for proper list rendering
- Mark goto call as void to indicate intentionally unused return value
fix: remove unused variables from QuestionCard #247
This commit removes the unused variables 'questionAnswer' and 'questionIcon'
to fix ESLint no-unused-vars warnings and clean up the component.
Refs #247
fix: remove unused imports and props from PdfCard #247
This commit removes unused components, variables, and props from PdfCard
to resolve ESLint no-unused-vars errors and clean up the component.
Refs #247
fix: clean up FilterButton props and add key to each block #247
This commit removes unused props from FilterButton and adds a unique key
to the each block to satisfy ESLint and Svelte requirements.
Refs #247
fix: replace unused params with fetch in load function #244
- Remove unused `params` parameter from load function
- Add `fetch` parameter to enable API calls
- Remove unnecessary console.log statement
fix: resolve ESLint no-undef errors for window and document #247
This commit fixes ESLint no-undef errors by safely accessing window and document
via globalThis inside onMount, ensuring compatibility with SSR and CI builds.
Refs #247
